remove old versions of processing-java when installing on OS X (fixes #3786)

app/src/processing/app/tools/InstallCommander.java

@@ -106,7 +106,12 @@ public class InstallCommander implements Tool {
         // with OS X 10.11 and its "System Integrity Protection"
         // https://github.com/processing/processing/issues/3497
         String targetPath = "/usr/local/bin/processing-java";
-        String shellScript = "/bin/mkdir -p /usr/local/bin && /bin/mv " + sourcePath + " " + targetPath;
+        // Remove the old version in case it exists
+        // https://github.com/processing/processing/issues/3786
+        String oldPath = "/usr/bin/processing-java";
+        String shellScript = "/bin/rm -f " + oldPath +
+          " && /bin/mkdir -p /usr/local/bin" +
+          " && /bin/mv " + sourcePath + " " + targetPath;
         String appleScript =
           "do shell script \"" + shellScript + "\" with administrator privileges";
         PApplet.exec(new String[] { "osascript", "-e", appleScript });
@@ -127,7 +132,7 @@ public class InstallCommander implements Tool {
 
     } catch (IOException e) {
       Messages.showWarning("Error while installing",
-                           "An error occurred and the tools were not installed.", e);
+                           "An error occurred and the tool was not installed.", e);
     }
   }
 

core/todo.txt

@@ -5,6 +5,11 @@ X   https://github.com/processing/processing/pull/3737
 X   https://github.com/processing/processing/issues/3761
 X add the Contents/Java folder to java.library.path on OS X
 X   allows exported applications to use the Sound library
+o don't grab pixels of java2d images unless asked
+o   this is the difference between a lot of loadPixels() and not
+o   so important to have it in before beta if that's the change
+o   https://github.com/processing/processing/issues/99
+X   won't fix for now, requires too much reworking on the image system
 
 andres
 X P2D: error calling surface.setTitle()
@@ -22,6 +27,12 @@ X Demos/Graphics/Wiggling regressed from 17 fps to 8.3 fps between a11 and b1
 X   https://github.com/processing/processing/issues/3561
 X "Library not installed properly" message inconsistent in P2D/P3D vs. JAVA2D
 X   https://github.com/processing/processing/issues/3453
+X PShape 3D: strange extra lines (another fix)
+X   https://github.com/processing/processing/issues/3006
+X line direction vectors are incorrectly transformed
+X   https://github.com/processing/processing/issues/3779
+X Strokes in 3D PShapes are not properly connected
+X   https://github.com/processing/processing/issues/3756
 
 jakub
 X FX - fix transformation stack NPE
@@ -68,6 +79,8 @@ X FX - fix bug where fonts would share a tint cache
 X   https://github.com/processing/processing/pull/3771
 X textFont() and textSize() are each calling one another
 X move createFont() to PGraphics
+X Fix PShape creation in P3D 
+X   https://github.com/processing/processing/pull/3781
 
 
 3.0 final
@@ -94,6 +107,8 @@ _ SVG only exports last frame
 _   possibly because Java2D is disposing the Graphics2D in between?
 _   https://github.com/processing/processing/issues/3753
 
+_ selectInput/Output() is behind the drawing window (Windows)
+_   https://github.com/processing/processing/issues/3775
 
 javafx
 _ need keyPressed() to do lower and upper case
@@ -464,10 +479,6 @@ CORE / PImage
 _ TGA files writing strangely
 _   https://github.com/processing/processing/issues/2096
 
-_ don't grab pixels of java2d images unless asked
-_   this is the difference between a lot of loadPixels() and not
-_   so important to have it in before beta if that's the change
-_   https://github.com/processing/processing/issues/99
 _ loadPixels() implementation needs to be in PApplet, not PGraphics
 _ this is a tricky thing to implement because of how OpenGL is handled
 

todo.txt

@@ -9,17 +9,29 @@ X deal with ConcurrentModificationException in Editor
 X   "Error repainting line range" and ConcurrentModificationException 
 X   https://github.com/processing/processing/issues/3726
 X repairs to prevent memory leak in EditorConsole
+o Claim that an exported application does not copy data directory
+X   https://github.com/processing/processing/issues/3777
+X   copying just fine
+X remove old versions of processing-java when installing on OS X
+X   https://github.com/processing/processing/issues/3786
 
 _ add jar files from 'code' folder to the library path
 _   Code editor wrongly detects errors for libraries in code folder
 _   https://github.com/processing/processing/issues/3732
-_ remove old versions of processing-java when installing on OS X
 _ "color type detected! this shouldn't be happening! please report"
 _   happens when user does 'new color' instead of 'color'
 _   https://github.com/processing/processing/issues/3739
 _ confusion when // tweak is used
 _   https://github.com/processing/processing/issues/3742
 
+jakub
+X Error/warning location visualisation not updating when editor resizes
+X   https://github.com/processing/processing/issues/3619
+X   https://github.com/processing/processing/pull/3778
+X "unexpected token" on anonymous instance of parameterized Comparator
+X   https://github.com/processing/processing/issues/533
+X   https://github.com/processing/processing/pull/3780
+
 contribs
 X Code auto-complete not working when Box2D library imported
 X   https://github.com/processing/processing/issues/3720
@@ -53,7 +65,6 @@ X   https://github.com/processing/processing/pull/3684
 X Ready to add contributed example packages?
 X   https://github.com/processing/processing/issues/2953
 
-
 known issues
 _ launch4j doesn't work from folders with non-native charsets
 _   anything in CP1252 on an English Windows system is fine
@@ -88,6 +99,8 @@ _   http://happygiraffe.net/blog/2009/09/24/java-platform-encoding/
 _   fix: get sun.jnu.encoding and make sure the user name is supported in it?
 _     and if not, put up a warning for the user?
 _   http://www.oracle.com/us/technologies/java/locale-140624.html
+_ Red error underline is sometimes at wrong location
+_   https://github.com/processing/processing/issues/3759
 
 
 sketch modified externally (3.0 final)
@@ -104,8 +117,6 @@ _ don't allow breakpoints to be set on blank lines
 _   https://github.com/processing/processing/issues/3765
 _ different design of squiggly line?
 _ build custom scroll bar since the OS versions are so ugly?
-_ Error/warning location visualisation not updating when editor resizes
-_   https://github.com/processing/processing/issues/3619
 _ error/warning location is awkward when no scroll bar is in use
 _ show hover text when the mouse is over the 'debug' button
 _ show number of updates available in the footer