eessppeelllloo/processing4
1
0
Fork 0
mirror of https://github.com/processing/processing4.git synced 2026-02-03 13:49:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

find a workaround for Help menu bug on macOS (fixes #638)

Browse Source
This commit is contained in:
Ben Fry
2023-01-16 08:07:46 -05:00
parent fd46805851
commit eed7066e54
2 changed files with 16 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
app/src/processing/app/ui/Editor.java
View File

@@ -633,7 +633,19 @@ public abstract class Editor extends JFrame implements RunnerListener {
base.populateToolsMenu(toolsMenu);
menubar.add(toolsMenu);
menubar.add(buildHelpMenu());
JMenu helpMenu = buildHelpMenu();
if (Platform.isMacOS()) {
// There's a bug on macOS since at least 2016 that leaves the
// Help menu disabled after a modal dialog has been shown.
// In 2018, it was closed by Oracle with a claim that it couldn't
// be reproduced: https://bugs.openjdk.org/browse/JDK-8196655
// The workaround is to add a space to the end of the menu name,
// which disables whatever macOS behavior is causing the problem.
// https://github.com/processing/processing4/issues/638
helpMenu.setText(helpMenu.getText() + " ");
}
menubar.add(helpMenu);
Toolkit.setMenuMnemonics(menubar);
setJMenuBar(menubar);
}

7
todo.txt
View File

@@ -1,5 +1,7 @@
1290 (4.1.2?)
X Help Menu disabled on OS X (looks like a JVM bug)
X https://github.com/processing/processing/issues/4353#issuecomment-237715947
X https://github.com/processing/processing4/issues/617
contributed
X “Cannot find a class or type named ‘PApplet’” error
@@ -825,9 +827,6 @@ _ https://github.com/processing/processing4/issues/234
_ we're not posting any, can we suppress the "allow notifications" message?
_ https://developer.apple.com/documentation/usernotifications
_ https://developer.apple.com/documentation/usernotifications/asking_permission_to_use_notifications
_ Help Menu disabled on OS X (looks like a JVM bug)
_ https://github.com/processing/processing/issues/4353#issuecomment-237715947
_ still broken in 11.0.8
_ Java bug prevents us from setting the dock name of a sketch run from the PDE
_ https://github.com/processing/processing/issues/5045
_ client properties