eessppeelllloo/vimix
1
0
Fork 0
mirror of https://github.com/brunoherbelin/vimix.git synced 2025-12-18 13:49:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

BugFix play bounce and seek mode

Browse Source 
Probably due to gstreamer change of implementation: to check if still backward compatible
This commit is contained in:
Bruno Herbelin
2023-12-26 14:31:02 +01:00
parent e8daeb5f30
commit a529b34f99
1 changed files with 15 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/MediaPlayer.cpp
View File

@@ -502,6 +502,11 @@ void MediaPlayer::execute_open()
// //
void MediaPlayer::execute_open() void MediaPlayer::execute_open()
{ {
// filters and audio are not available without playbin
video_filter_available_ = false;
audio_enabled_ = false;
media_.hasaudio = false;
// Create gstreamer pipeline : // Create gstreamer pipeline :
// "uridecodebin uri=file:///path_to_file/filename.mp4 ! videoconvert ! appsink " // "uridecodebin uri=file:///path_to_file/filename.mp4 ! videoconvert ! appsink "
// equivalent to command line // equivalent to command line
@@ -1272,6 +1277,7 @@ void MediaPlayer::update()
// seek should be resolved next frame // seek should be resolved next frame
seeking_ = false; seeking_ = false;
// do NOT do another seek yet // do NOT do another seek yet
need_loop = false;
} }
// otherwise check for need to seek (pipeline management) // otherwise check for need to seek (pipeline management)
else if (position_ != GST_CLOCK_TIME_NONE) { else if (position_ != GST_CLOCK_TIME_NONE) {
@@ -1313,10 +1319,10 @@ void MediaPlayer::execute_loop_command()
{ {
if (loop_==LOOP_REWIND) { if (loop_==LOOP_REWIND) {
rewind(); rewind();
} } else if (loop_ == LOOP_BIDIRECTIONAL) {
else if (loop_==LOOP_BIDIRECTIONAL) { rate_ *= -1.f;
rate_ *= - 1.f;
execute_seek_command(); execute_seek_command();
// execute_seek_command(position_ + (rate_ > 0.f ? media_.dt : media_.dt));
} }
else { //LOOP_NONE else { //LOOP_NONE
if (desired_state_ == GST_STATE_PLAYING) // avoid repeated call if (desired_state_ == GST_STATE_PLAYING) // avoid repeated call
@@ -1345,10 +1351,11 @@ void MediaPlayer::execute_seek_command(GstClockTime target, bool force)
// seek with flush (always) // seek with flush (always)
int seek_flags = GST_SEEK_FLAG_FLUSH; int seek_flags = GST_SEEK_FLAG_FLUSH;
// seek with trick mode if fast speed if ( desired_state_ == GST_STATE_PLAYING )
if ( ABS(rate_) > 1.5 ) // seek with KEY mode if playing
seek_flags |= GST_SEEK_FLAG_TRICKMODE; seek_flags |= GST_SEEK_FLAG_KEY_UNIT | GST_SEEK_FLAG_SNAP_AFTER;
else else
// seek with accurate timing if paused
seek_flags |= GST_SEEK_FLAG_ACCURATE; seek_flags |= GST_SEEK_FLAG_ACCURATE;
// create seek event depending on direction // create seek event depending on direction
@@ -1434,8 +1441,9 @@ void MediaPlayer::setPlaySpeed(double s)
// Generic way is a flush seek // Generic way is a flush seek
// following the example from // following the example from
// https://gstreamer.freedesktop.org/documentation/tutorials/basic/playback-speed.html // https://gstreamer.freedesktop.org/documentation/tutorials/basic/playback-speed.html
else else {
execute_seek_command(); execute_seek_command();
}
// Set after initialization (will be used next time) // Set after initialization (will be used next time)
if (rate_change_ == RATE_CHANGE_NONE) if (rate_change_ == RATE_CHANGE_NONE)