eessppeelllloo/vimix
1
0
Fork 0
mirror of https://github.com/brunoherbelin/vimix.git synced 2025-12-11 18:34:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Programming style improvement: following Cppcheck suggestions.

Browse Source
This commit is contained in:
brunoherbelin
2021-04-04 13:13:06 +02:00
parent b4627a1613
commit f443720319
51 changed files with 269 additions and 271 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
Session.cpp
View File

@@ -11,10 +11,8 @@
#include "Log.h"
Session::Session() : failedSource_(nullptr), active_(true), fading_target_(0.f)
Session::Session() : failedSource_(nullptr), active_(true), fading_target_(0.f), filename_("")
{
filename_ = "";
config_[View::RENDERING] = new Group;
config_[View::RENDERING]->scale_ = glm::vec3(0.f);
@@ -77,7 +75,7 @@ void Session::update(float dt)
// pre-render of all sources
failedSource_ = nullptr;
for( SourceList::iterator it = sources_.begin(); it != sources_.end(); it++){
for( SourceList::iterator it = sources_.begin(); it != sources_.end(); ++it){
// ensure the RenderSource is rendering this session
RenderSource *s = dynamic_cast<RenderSource *>( *it );
@@ -125,13 +123,11 @@ void Session::update(float dt)
SourceList::iterator Session::addSource(Source *s)
{
SourceList::iterator its = sources_.end();
// lock before change
access_.lock();
// find the source
its = find(s);
SourceList::iterator its = find(s);
// ok, its NOT in the list !
if (its == sources_.end()) {
@@ -297,7 +293,7 @@ SourceList::iterator Session::at(int index)
SourceList::iterator it = sources_.begin();
while ( i < index && it != sources_.end() ){
i++;
it++;
++it;
}
return it;
}
@@ -325,7 +321,7 @@ void Session::move(int current_index, int target_index)
SourceList::iterator from = at(current_index);
SourceList::iterator to = at(target_index);
if ( target_index > current_index )
to++;
++to;
Source *s = (*from);
sources_.erase(from);