eessppeelllloo/ffmpeg
1
0
Fork 0
mirror of https://git.ffmpeg.org/ffmpeg.git synced 2026-06-16 04:32:47 +02:00
Code Issues Packages Projects Releases Wiki Activity

checkasm/hevc_pel: fix typo size[sizes] -> sizes[size]

Browse Source 
Commit 4d4b301e4a introduced a typo where `size[sizes]` was used
instead of `sizes[size]` in 10 places within checkasm_check_pixel_padded
calls.

Since `sizes` is an array and `size` is the loop index, `size[sizes]`
interprets the array pointer as an index, resulting in undefined behavior
and causing AddressSanitizer to detect buffer overflows during testing.

Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
This commit is contained in:
Jun Zhao
2026-01-31 00:09:17 +08:00
committed by Jun Zhao
parent 2df0ef601a
commit 2801d5eafe
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/checkasm/hevc_pel.c
+10 -10
View File
@@ -110,7 +110,7 @@ static void checkasm_check_hevc_qpel(void)
call_new(dstw1, src1, sizes[size] * SIZEOF_PIXEL, sizes[size], i, j, sizes[size]);
checkasm_check(int16_t, dstw0, MAX_PB_SIZE * sizeof(int16_t),
dstw1, MAX_PB_SIZE * sizeof(int16_t),
size[sizes], size[sizes], "dst");
sizes[size], sizes[size], "dst");
bench_new(dstw1, src1, sizes[size] * SIZEOF_PIXEL, sizes[size], i, j, sizes[size]);
}
}
@@ -159,7 +159,7 @@ static void checkasm_check_hevc_qpel_uni(void)
sizes[size], i, j, sizes[size]);
checkasm_check_pixel_padded(dst0, dst0_stride,
dst1, dst1_stride,
size[sizes], size[sizes], "dst");
sizes[size], sizes[size], "dst");
bench_new(dst1, dst1_stride,
src1, sizes[size] * SIZEOF_PIXEL,
sizes[size], i, j, sizes[size]);
@@ -214,7 +214,7 @@ static void checkasm_check_hevc_qpel_uni_w(void)
sizes[size], *denom, *wx, *ox, i, j, sizes[size]);
checkasm_check_pixel_padded(dst0, dst0_stride,
dst1, dst1_stride,
size[sizes], size[sizes], "dst");
sizes[size], sizes[size], "dst");
bench_new(dst1, dst1_stride,
src1, sizes[size] * SIZEOF_PIXEL,
sizes[size], *denom, *wx, *ox, i, j, sizes[size]);
@@ -271,7 +271,7 @@ static void checkasm_check_hevc_qpel_bi(void)
ref1, sizes[size], i, j, sizes[size]);
checkasm_check_pixel_padded(dst0, dst0_stride,
dst1, dst1_stride,
size[sizes], size[sizes], "dst");
sizes[size], sizes[size], "dst");
bench_new(dst1, dst1_stride,
src1, sizes[size] * SIZEOF_PIXEL,
ref1, sizes[size], i, j, sizes[size]);
@@ -330,7 +330,7 @@ static void checkasm_check_hevc_qpel_bi_w(void)
ref1, sizes[size], *denom, *wx, *wx, *ox, *ox, i, j, sizes[size]);
checkasm_check_pixel_padded(dst0, dst0_stride,
dst1, dst1_stride,
size[sizes], size[sizes], "dst");
sizes[size], sizes[size], "dst");
bench_new(dst1, dst1_stride,
src1, sizes[size] * SIZEOF_PIXEL,
ref1, sizes[size], *denom, *wx, *wx, *ox, *ox, i, j, sizes[size]);
@@ -383,7 +383,7 @@ static void checkasm_check_hevc_epel(void)
call_new(dstw1, src1, sizes[size] * SIZEOF_PIXEL, sizes[size], i, j, sizes[size]);
checkasm_check(int16_t, dstw0, MAX_PB_SIZE * sizeof(int16_t),
dstw1, MAX_PB_SIZE * sizeof(int16_t),
size[sizes], size[sizes], "dst");
sizes[size], sizes[size], "dst");
bench_new(dstw1, src1, sizes[size] * SIZEOF_PIXEL, sizes[size], i, j, sizes[size]);
}
}
@@ -432,7 +432,7 @@ static void checkasm_check_hevc_epel_uni(void)
sizes[size], i, j, sizes[size]);
checkasm_check_pixel_padded(dst0, dst0_stride,
dst1, dst1_stride,
size[sizes], size[sizes], "dst");
sizes[size], sizes[size], "dst");
bench_new(dst1, dst1_stride,
src1, sizes[size] * SIZEOF_PIXEL,
sizes[size], i, j, sizes[size]);
@@ -487,7 +487,7 @@ static void checkasm_check_hevc_epel_uni_w(void)
sizes[size], *denom, *wx, *ox, i, j, sizes[size]);
checkasm_check_pixel_padded(dst0, dst0_stride,
dst1, dst1_stride,
size[sizes], size[sizes], "dst");
sizes[size], sizes[size], "dst");
bench_new(dst1, dst1_stride,
src1, sizes[size] * SIZEOF_PIXEL,
sizes[size], *denom, *wx, *ox, i, j, sizes[size]);
@@ -544,7 +544,7 @@ static void checkasm_check_hevc_epel_bi(void)
ref1, sizes[size], i, j, sizes[size]);
checkasm_check_pixel_padded(dst0, dst0_stride,
dst1, dst1_stride,
size[sizes], size[sizes], "dst");
sizes[size], sizes[size], "dst");
bench_new(dst1, dst1_stride,
src1, sizes[size] * SIZEOF_PIXEL,
ref1, sizes[size], i, j, sizes[size]);
@@ -603,7 +603,7 @@ static void checkasm_check_hevc_epel_bi_w(void)
ref1, sizes[size], *denom, *wx, *wx, *ox, *ox, i, j, sizes[size]);
checkasm_check_pixel_padded(dst0, dst0_stride,
dst1, dst1_stride,
size[sizes], size[sizes], "dst");
sizes[size], sizes[size], "dst");
bench_new(dst1, dst1_stride,
src1, sizes[size] * SIZEOF_PIXEL,
ref1, sizes[size], *denom, *wx, *wx, *ox, *ox, i, j, sizes[size]);